-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
04-live-data-and-view-model #11
Open
Serchinastico
wants to merge
1
commit into
03b-advanced-data-binding
Choose a base branch
from
04-live-data-and-view-model
base: 03b-advanced-data-binding
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
04-live-data-and-view-model #11
Serchinastico
wants to merge
1
commit into
03b-advanced-data-binding
from
04-live-data-and-view-model
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4da947e
to
6ccc843
Compare
tonilopezmr
approved these changes
Feb 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 👍
davideme
reviewed
Feb 5, 2019
app/src/androidTest/java/com/karumi/jetpack/superheroes/data/singleValueLiveData.kt
Show resolved
Hide resolved
davideme
reviewed
Feb 5, 2019
app/src/main/java/com/karumi/jetpack/superheroes/common/ViewModelFactory.kt
Show resolved
Hide resolved
davideme
approved these changes
Feb 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
6ccc843
to
eaaadc0
Compare
7caf147
to
f2cd3e3
Compare
e5b3c72
to
592849a
Compare
f2cd3e3
to
b508ca6
Compare
592849a
to
2a59248
Compare
b508ca6
to
f21ea81
Compare
2a59248
to
d9da96b
Compare
f21ea81
to
3f37772
Compare
d9da96b
to
7482884
Compare
3f37772
to
6e0488d
Compare
7482884
to
6100eb2
Compare
a20a140
to
52e37d2
Compare
5a956ff
to
e80f6af
Compare
52e37d2
to
5ce5d5b
Compare
e80f6af
to
2fa910d
Compare
5ce5d5b
to
1f02122
Compare
2fa910d
to
46cf2b2
Compare
1f02122
to
c4f1224
Compare
46cf2b2
to
7ac91df
Compare
c4f1224
to
667bf7d
Compare
7ac91df
to
dd31b7c
Compare
667bf7d
to
cd94eca
Compare
Migrate edit super hero screen Migrate main screen to view model WIP
dd31b7c
to
e3f613c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not meant to be merged
This is how to use LiveData and ViewModel components:
addSource
fromMediatorLiveData
will behave oddly otherwise.